Skip to content

Set support version of node.js explicitly as 6, 8, 9.#28

Merged
NoahDragon merged 2 commits intohexojs:masterfrom
segayuu:support-node-version-6
Mar 29, 2018
Merged

Set support version of node.js explicitly as 6, 8, 9.#28
NoahDragon merged 2 commits intohexojs:masterfrom
segayuu:support-node-version-6

Conversation

@segayuu
Copy link
Contributor

@segayuu segayuu commented Mar 29, 2018

In the current setting of travis-ci, test target is v6 and stable.

Therefore, it can not be said that it actually supports the previous version.
So, you should explicitly write support version in package.json.

When this PR is applied, I plan to do semiautomatic refactoring using lebab, PR to upgrade each package, and so on.

@segayuu segayuu requested a review from NoahDragon March 29, 2018 02:22
@coveralls
Copy link

coveralls commented Mar 29, 2018

Coverage Status

Coverage remained the same at 85.816% when pulling ad0f639 on segayuu:support-node-version-6 into da449e6 on hexojs:master.

@NoahDragon NoahDragon merged commit b6442e6 into hexojs:master Mar 29, 2018
Copy link
Member

@NoahDragon NoahDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@segayuu segayuu deleted the support-node-version-6 branch March 29, 2018 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants