Closed
Conversation
Member
|
This patch is good. I highly recommend to merge it. |
Member
|
Fixed in 3.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tommy351 wrapped each line with
<div class="line">to fix #687, however, there was a problem with codes with blank lines just like #792 and #774.Adding css style for
.linemay be a solution, but it's hard to let all the themes change their css files, I think usingspaninstead ofdivand adding\nfor each line can fix this issue without changing the css files, but I am not sure whether it will cause the same problem in #687. (I don't have the same problem in that issue before wrapping the line withdiv).