Merged
Conversation
How to testgit clone -b eslint https://github.com/hexojs/hexo.git
cd hexo
npm install
npm test |
2 tasks
yoshinorin
reviewed
Dec 31, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
@uiolee |
Member
|
about "n/no-missing-import", full path is required. Maybe we need change our code style. |
Pull Request Test Coverage Report for Build 14560644494Details
💛 - Coveralls |
Co-authored-by: yoshinorin <yoshinorin.net@outlook.com> Signed-off-by: Mimi <stevenjoezhang@gmail.com>
Signed-off-by: D-Sketon <2055272094@qq.com>
Member
Author
|
I made some updates, ESLint no longer throws errors now. |
Member
How about adding a const config = require('eslint-config-hexo/ts');
module.exports = [
...config,
{
'rules': {
'@typescript-eslint/no-explicit-any': 0,
'@typescript-eslint/no-var-requires': 0,
'@typescript-eslint/no-require-imports': 0,
'n/no-missing-require': 0,
'n/no-missing-import': 0,
+ "@typescript-eslint/no-unused-vars": [
+ "error",
+ {
+ "argsIgnorePattern": "^_"
+ }
+ ]
}
}
];- // eslint-disable-next-line @typescript-eslint/no-unused-vars
- run(context, args, body, callback) {
+ run(context, args, _body, _callback) {
return this._run(context, args, '');
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What does it do?
See hexojs/eslint-config-hexo#64
Screenshots
Pull request tasks