revert: Access data files from source folder (#1969)#5325
Merged
stevenjoezhang merged 1 commit intov7.0.0from Oct 23, 2023
Merged
revert: Access data files from source folder (#1969)#5325stevenjoezhang merged 1 commit intov7.0.0from
stevenjoezhang merged 1 commit intov7.0.0from
Conversation
How to testgit clone -b data https://github.com/hexojs/hexo.git
cd hexo
npm install
npm test |
5 tasks
uiolee
approved these changes
Oct 22, 2023
Member
|
breaking change？ |
Member
Author
|
Yes, it is a breaking change, we could include it in the v7.0.0 release. However, I don't think it's necessary to add a new option. This usage is not mentioned in Hexo's documentation; it's a completely undocumented interface. We don't need to consider its stability and compatibility. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
reverts #1969
fixes #5260
Motivation for the modification: I suspect that this feature is rarely used (I noticed it for the first time today). In fact, users can access the 'site' variable through the template engine, without the need for tags within the article.
Screenshots
Pull request tasks