feat: define global variable hexo#5242
Merged
yoshinorin merged 1 commit intohexojs:v7.0.0from Aug 10, 2023
Merged
Conversation
useful for plugin written in typescript or let IDE detecting it
How to testgit clone -b define-global-var https://github.com/dimaslanjaka/hexo.git
cd hexo
npm install
npm test |
Contributor
Author
|
@SukkaW review pls |
yoshinorin
approved these changes
Jul 25, 2023
Member
yoshinorin
left a comment
There was a problem hiding this comment.
LGTM 👍
@hexojs/core
Do you have any concerns? If not (or if no-reply for a while), I will merge this.
Thank you :)
himself65
approved these changes
Aug 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useful for plugin written in typescript or let IDE detecting it
What does it do?
Add global variable
hexo. Since the release of TypeScript 3.4 there's a documented way to do it.Useful for plugin written in typescript or let IDE typechecking detecting hexo.
Screenshots
script inside
scriptsfolder automated detect global hexo without setting anything on IDE.plugin using typescript.
demo improvement.
https://github.com/dimaslanjaka/hexo/tree/monorepo-v7/releases
Pull request tasks