fix: create post with a path composed of numbers throw an error#5117
Closed
D-Sketon wants to merge 1 commit intohexojs:masterfrom
Closed
fix: create post with a path composed of numbers throw an error#5117D-Sketon wants to merge 1 commit intohexojs:masterfrom
D-Sketon wants to merge 1 commit intohexojs:masterfrom
Conversation
How to testgit clone -b fix_4334 https://github.com/D-Sketon/hexo.git
cd hexo
npm install
npm test |
Member
|
There will be an edge case: You can try to change the code here: https://github.com/hexojs/hexo-cli/blob/5c5fc8fe2fc781a557a30f1bf2043502825f173c/lib/hexo.ts#L18 minimist(process.argv.slice(2), { string: ['_', 'p', 'path'] })should work |
Member
|
See also hexojs/hexo-cli#200 |
Member
Author
|
@stevenjoezhang should |
Member
2 tasks
Member
Author
|
@stevenjoezhang I'm a bit confused, do I just need to add extra test cases in this PR? |
Member
|
It's tricky to cover this situation with unit tests, need to hook |
Member
Author
|
Superseded by #5465 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
fix #4334
Screenshots
Pull request tasks