Skip to content

fix(#1099): hexo server error when changing the config#5055

Merged
yoshinorin merged 2 commits intohexojs:masterfrom
D-Sketon:new_feature
Oct 5, 2022
Merged

fix(#1099): hexo server error when changing the config#5055
yoshinorin merged 2 commits intohexojs:masterfrom
D-Sketon:new_feature

Conversation

@D-Sketon
Copy link
Member

@D-Sketon D-Sketon commented Sep 9, 2022

What does it do?

Fix #1099.

When new_post_name lacks :title, new_post_name is used as the slug.

Screenshots

None.

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

How to test

git clone -b new_feature https://github.com/D-Sketon/hexo.git
cd hexo
npm install
npm test

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 98.329% when pulling 255ea82 on D-Sketon:new_feature into 4d42d9d on hexojs:master.

Copy link
Member

@renbaoshuo renbaoshuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add test cases for the changes?

@D-Sketon
Copy link
Member Author

D-Sketon commented Sep 9, 2022

Could you please add test cases for the changes?

@renbaoshuo New test cases have been added

Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@D-Sketon
LGTM. Thank you :)

@yoshinorin yoshinorin merged commit 8aac336 into hexojs:master Oct 5, 2022
@yoshinorin yoshinorin added this to the 7.0.0 milestone Oct 5, 2022
@stevenjoezhang stevenjoezhang mentioned this pull request Nov 30, 2022
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hexo server error when I change the config

4 participants