Skip to content

chore/test: use chai#should#4902

Merged
SukkaW merged 1 commit intohexojs:masterfrom
SukkaW:chai-register-should
Feb 25, 2022
Merged

chore/test: use chai#should#4902
SukkaW merged 1 commit intohexojs:masterfrom
SukkaW:chai-register-should

Conversation

@SukkaW
Copy link
Member

@SukkaW SukkaW commented Feb 24, 2022

What does it do?

This deprecates the old require('chai/register-should') which causes the test to fail.

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@github-actions
Copy link

How to test

git clone -b chai-register-should https://github.com/SukkaW/hexo.git
cd hexo
npm install
npm test

Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SukkaW SukkaW merged commit 3e3c4ba into hexojs:master Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants