You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hexo uses browserify's resolve to resolve a path of a plugin by default, which is incompatible with @vercel/nft. See also: vercel/nft#257
So we use Node.js's built-in require.resolve by default (which is compatible with @vercel/nft), fallback to resolve.sync only when the module is not found (or other errors).
Since there are no other significant behavior differences (from hexo's usage) between resolve.sync and require.resolve, we should drop resolve from dependency in the future.
How to test
git clone -b fix-plugin-resolve https://github.com/sukkaw/hexo.git
cd hexo
npm install
npm test
I approve, but unable to fully understand this change and its potential impacts
The API require.resolve is introduced in Node.js since 0.3.0, however it doesn't support limit scope resolving (only search dependency in the given directories' node_modules, in our case is user's hexo folder) back then. That's probably why package resolve (made by browserify) is used (it provides a base_dir option).
And since Node.js 8.9.0, require.resolve accepted the second argument, which enables to only search under specific given paths.
It shouldn't have any impact at all. And in case there is any, I still use the old resolve package as a fallback, trying to avoid a breaking change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tomap
left a comment
What does it do?
Hexo uses browserify's
resolveto resolve a path of a plugin by default, which is incompatible with@vercel/nft. See also: vercel/nft#257So we use Node.js's built-in
require.resolveby default (which is compatible with@vercel/nft), fallback toresolve.synconly when the module is not found (or other errors).Since there are no other significant behavior differences (from hexo's usage) between
resolve.syncandrequire.resolve, we should dropresolvefrom dependency in the future.How to test
Screenshots
Pull request tasks