Skip to content

fix(disableNunjucks): query both async and sync versions of renderer#4498

Merged
curbengh merged 2 commits intohexojs:masterfrom
curbengh:disable-nunjucks-sync
Aug 28, 2020
Merged

fix(disableNunjucks): query both async and sync versions of renderer#4498
curbengh merged 2 commits intohexojs:masterfrom
curbengh:disable-nunjucks-sync

Conversation

@curbengh
Copy link
Contributor

@curbengh curbengh commented Aug 26, 2020 •
edited
Loading

What does it do?

A workaround to fix #3860, disableNunjucks may not be reliable in synchronous mode. The issue could be due to Promise.method() not including disableNunjucks property.

Before: https://github.com/hexojs/hexo-renderer-coffeescript/pull/72/checks?check_run_id=1030164260
After: https://github.com/hexojs/hexo-renderer-coffeescript/pull/72/checks?check_run_id=1030174895

How to test

git clone -b BRANCH https://github.com/USER/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

coveralls commented Aug 26, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 98.299% when pulling bdd4156 on curbengh:disable-nunjucks-sync into 08c8b23 on hexojs:master.

@curbengh curbengh marked this pull request as ready for review August 27, 2020 03:07
curbengh
curbengh commented Aug 27, 2020
View reviewed changes
@curbengh curbengh changed the title fix(disableNunjucks): attempt both async and sync versions of renderer fix(disableNunjucks): query both async and sync versions of renderer Aug 27, 2020
SukkaW
SukkaW reviewed Aug 27, 2020
View reviewed changes
@curbengh curbengh force-pushed the disable-nunjucks-sync branch from 7b02c13 to bdd4156 Compare August 28, 2020 04:35
This was referenced Aug 28, 2020
Closed
Closed
@curbengh curbengh merged commit 7fbfc99 into hexojs:master Aug 28, 2020
@curbengh curbengh deleted the disable-nunjucks-sync branch August 28, 2020 10:03
@curbengh curbengh mentioned this pull request Sep 5, 2020
Merged
@stevenjoezhang stevenjoezhang mentioned this pull request Nov 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SukkaW SukkaW SukkaW approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inconsistent check for Nunjucks disabling flag

3 participants

@curbengh @coveralls @SukkaW