Depending on use case, asset_path tag plugin might not need to encode url.

Coverage decreased (-0.01%) to 97.237% when pulling 382b0de on curbengh:encode-url-helper into ffe4eaa on hexojs:master.

url_for pending hexojs/hexo-util#82

Should we re-implement those helper using hexo-util?

For example:

// url_for.js
'use strict';

module.exports = function (path = '/', options) {
  const url_for = require('hexo-util').url_for.bind(this);
  return url_for(path, options)
};

Should we re-implement those helper using hexo-util?

Definitely, once hexo-util v1.2.0 is published. To be refactored (in a separate PR):

• relative_url
• gravatar
• full_url_for

Ready to review.

Just realized path is encoded twice if it's already encode (/foo/bar%20baz -> /foo/bar%25%20baz). Pending hexojs/hexo-util#92

WIP, needs to utilize url_for() more.

Edit: refactored.

Pending hexojs/hexo-util#92 & hexojs/hexo-util#94 to avoid encoding path twice.

I have no idea why the test on AppVeyor failed while the test on Travis CI successed.

I have no idea why the test on AppVeyor failed while the test on Travis CI successed.

The test failure shows the actual is "/foo%5Cbar" where %5C is a backslash, so it's Windows path.

This PR replaces url.resolve('/', asset.path); with encodeURL('/' + asset.path), the removal of url.resolve() could be the cause. I'll try putting it back, in combination with encodeURL.

Seems to resolve it, now left double-encoding issue.
Pending hexojs/hexo-util#92 & hexojs/hexo-util#99

Looks like full_url_for() and url_for() currently don't support Windows path. Perhaps adding url.resolve() in those functions can help.

Edit: url.resolve() in full_url_for() wouldn't help

const { resolve } = require('url')
console.log(resolve('http://example.com/blog/', 'abc\hey\index.html'))
// http://example.com/blog/abcheyindex.html

Anyhow, Windows path may not be applicable for full_url_for() / url_for().

html_tag of hexo-util needs to be updated for mail_to helper compatibility.

Located the issue:

const { parse } = require('url')
console.log(parse('mailto:abc@example.com'))
/*
Url {
  protocol: 'mailto:',
  slashes: null,
  auth: 'abc',
  host: 'example.com',
  port: null,
  hostname: 'example.com',
  hash: null,
  search: null,
  query: null,
  pathname: null,
  path: null,
  href: 'mail:abc@example.com'
}
*/

null path is appended, resulting in mailto:abc@example.comnull.

Fix created hexojs/hexo-util#102