Configs are now expanded for hexo-util/highlight to make it easier to…#2901
Merged
JLHwung merged 2 commits intohexojs:masterfrom Jan 7, 2018
Merged
Configs are now expanded for hexo-util/highlight to make it easier to…#2901JLHwung merged 2 commits intohexojs:masterfrom
JLHwung merged 2 commits intohexojs:masterfrom
Conversation
… expand upon plugins.
Contributor
Author
|
Ah, I just realized why Let me know what course of action is best. |
NoahDragon
approved these changes
Dec 16, 2017
Member
NoahDragon
left a comment
There was a problem hiding this comment.
LGTM. Note for npm publishing, make sure this change deployed with hexojs/hexo-util#30 .
4 tasks
This was referenced Nov 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of the code necessary to address #2145.
It simply expands
config.highlightinside of theoptionsobject that is passed tohexo-util/highlight.I went this route to make sure that the plugin remains backward compatible for themes and people who have already styled based on the current highlight engine.
This is a quick proof of concept, and if everything is fine, I will update the documentation accordingly.
The other part of the PR will be in
@hexojs/hexo-utilThe matching PR to support the added
highlight.hljssetting is located athexo-util/#30