Skip to content

Update versions for hotfix#463

Merged
thomaskrause merged 5 commits intomainfrom
hotfix/1.4.5
Oct 21, 2024
Merged

Update versions for hotfix#463
thomaskrause merged 5 commits intomainfrom
hotfix/1.4.5

Conversation

@sdruskat
Copy link
Copy Markdown
Contributor

Pull request type

  • Build related changes

What is the current behavior?

SonarCloud shows a warning for the last analysis:

Last analysis has warnings

The property 'sonar.login' is deprecated and will be removed in the future. Please use the 'sonar.token' property instead when passing a token."

grafik

What is the new behavior?

  • Changes the name of the respective property to sonar.token in the CI config.

Does this introduce a breaking change?

No

Other information

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added or the PR is neither a bug fix nor a feature
  • Docs have been reviewed and added / updated if needed or the PR is neither a bug fix nor a feature
  • The Unreleased section in CHANGELOG.md has been amended to reflect the changes in this PR if needed (not needed)
  • Build (mvn -Pcff verify) was run locally and any changes were pushed (Building on WSL2 Ubuntu with no X Window)
  • The pull request is against the correct branch (main for bug fixes, develop for new functionality)
  • Dependencies and citation templates have been updated where necessary or there are no new dependencies

Checklist for maintainers

Releases

  • Do NOT push the green merge button on GitHub.
    Follow the latest version of the developer/maintainer docs for making releases.
  • Check that license and citation information for dependencies are complete (each dependency has a folder in /THIRD-PARTY/).

@sdruskat sdruskat requested a review from thomaskrause October 18, 2024 18:29
@sdruskat sdruskat marked this pull request as ready for review October 18, 2024 18:29
@thomaskrause thomaskrause self-assigned this Oct 21, 2024
@thomaskrause thomaskrause added the bug Something isn't working label Oct 21, 2024
Copy link
Copy Markdown
Contributor

@thomaskrause thomaskrause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@thomaskrause thomaskrause merged commit 27c7946 into main Oct 21, 2024
@thomaskrause thomaskrause deleted the hotfix/1.4.5 branch October 21, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants