Skip to content

refactor(base): make list command generic#1132

Merged
phm07 merged 1 commit intomainfrom
list-base-command-refactor
Aug 27, 2025
Merged

refactor(base): make list command generic#1132
phm07 merged 1 commit intomainfrom
list-base-command-refactor

Conversation

@phm07
Copy link
Copy Markdown
Contributor

@phm07 phm07 commented Aug 20, 2025

Making list commands generic allows to remove a lot of code duplication and makes it easier to use the base command.

@phm07 phm07 self-assigned this Aug 20, 2025
@phm07 phm07 added the refactor label Aug 20, 2025
@phm07 phm07 requested a review from a team as a code owner August 20, 2025 13:27
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 20, 2025

Codecov Report

❌ Patch coverage is 98.55072% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.35%. Comparing base (f1fedd1) to head (117b2ce).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
internal/cmd/base/list.go 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1132      +/-   ##
==========================================
+ Coverage   64.00%   70.35%   +6.35%     
==========================================
  Files         244      244              
  Lines       10878    10677     -201     
==========================================
+ Hits         6962     7512     +550     
+ Misses       3183     2495     -688     
+ Partials      733      670      -63     
Flag Coverage Δ
e2e 52.00% <40.57%> (?)
unit 64.02% <98.55%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@phm07 phm07 merged commit 764878a into main Aug 27, 2025
7 checks passed
@phm07 phm07 deleted the list-base-command-refactor branch August 27, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants