Ember New Lang (WIP)#1
Closed
hergaiety wants to merge 51 commits into
Closed
Conversation
jgwhite
reviewed
May 4, 2020
jgwhite
reviewed
May 21, 2020
jgwhite
reviewed
May 21, 2020
jgwhite
reviewed
May 21, 2020
Co-authored-by: Jamie White <jameswhite@salesforce.com>
Co-authored-by: Jamie White <jameswhite@salesforce.com>
Co-authored-by: Jamie White <jameswhite@salesforce.com>
Co-authored-by: Melanie Sumner <melaniersumner@gmail.com>
Co-authored-by: Melanie Sumner <melaniersumner@gmail.com>
Update `Motivation` section per review
Update `Summary` section per review
Updating RFC draft per strike team meeting review
Update 0000-ember-new-lang.md
- added authors (since there are multiple) - added information based on the feedback from the [strike team's review](https://github.com/ember-a11y/core-notes/blob/ember-a11y/ember-a11y/2020-05/may-27.md)
Update 0000-ember-new-lang.md
updating for clarity (no wording changed)
finishing a sentence that didn't end.
Added additional detailed design info for cases where the `--lang` flag has no arguments defined
Update 0000-ember-new-lang.md
Update 0000-ember-new-lang.md
jgwhite
reviewed
May 29, 2020
Co-authored-by: Jamie White <jameswhite@salesforce.com>
Update to address feedback from @locks
Owner
Author
|
Closing this draft to not have confusion with the open RFC emberjs#635 @MelSumner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered
Candidate Implementation
Opened RFC: emberjs#635