fix: wrong type cache entry at expansion's start is not an error #935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the beginning of an expansion, a cache entry *not* holding a string does not necessarily mean the expansion can't be done, so avoid returning an error. Add cases to test the caches in these situations. Signed-off-by: Stoned Elipot <stoned.elipot@proton.me>
yxxhero
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the beginning of an expansion, a cache entry not holding a string does not necessarily mean the expansion can't be done, so avoid returning an error.
Add cases to test the caches in these situations.
As illustration, compare current version of vals' behavior with the proposed fix.
vs