Add Scaleway support #843
Merged
Add Scaleway support #843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f336f2f to
b81c7c0
Compare
Signed-off-by: CorentinPtrl <pitrel.corentin@gmail.com>
b81c7c0 to
57b3624
Compare
Signed-off-by: CorentinPtrl <pitrel.corentin@gmail.com>
02af0d0 to
6bfc95b
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Scaleway Secret Manager as a new provider in the vals configuration management tool. The integration allows users to retrieve secrets from Scaleway using the ref+scw:// URI scheme with authentication via environment variables.
Key changes:
- Added Scaleway provider implementation with support for both string and map retrieval
- Integrated the provider into the main registration system
- Added comprehensive tests for both opaque and JSON secret types
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/providers/scaleway/scaleway.go | Core Scaleway provider implementation with secret retrieval logic |
| vals_scaleway_test.go | Integration tests for string and JSON secret scenarios |
| vals.go | Provider registration and initialization in main runtime |
| pkg/stringprovider/stringprovider.go | String provider factory registration |
| pkg/stringmapprovider/stringmapprovider.go | String map provider factory registration |
| go.mod | Added Scaleway SDK dependency |
| README.md | Documentation for the new Scaleway provider |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like to have direct Scaleway support
This implementation uses the Scaleway Go SDK to access secrets stored in Scaleway Secret Manager . It authenticates using the environment variables SCW_PROJECT_ID (falling back to SCW_DEFAULT_PROJECT_ID if unset), SCW_REGION (falling back to SCW_DEFAULT_REGION if unset), SCW_ACCESS_KEY, and SCW_SECRET_KEY.