Skip to content

Add documentation about external files#1180

Closed
itaispiegel wants to merge 1 commit intohelm:mainfrom
itaispiegel:include-external-files
Closed

Add documentation about external files#1180
itaispiegel wants to merge 1 commit intohelm:mainfrom
itaispiegel:include-external-files

Conversation

@itaispiegel
Copy link

I added documentation for my PR in Helm: helm/helm#10077 :)

Signed-off-by: itaispiegel itai.spiegel@gmail.com

Signed-off-by: itaispiegel <itai.spiegel@gmail.com>
@bridgetkromhout bridgetkromhout added the awaiting release Feature needs to be merged and released before docs update label Sep 22, 2021
@bridgetkromhout bridgetkromhout added awaiting review and removed awaiting release Feature needs to be merged and released before docs update labels Dec 2, 2021
@bridgetkromhout
Copy link
Member

Hi, @itaispiegel - Thanks for submitting this docs update! We review docs updates after the related code changes are approved, and merge when the code changes are released. I see that I labeled this "awaiting release", but the correct label is "awaiting review", which I have now set. We will be able to review this when the PR is finalized. Thanks!

@itaispiegel
Copy link
Author

Hi, @itaispiegel - Thanks for submitting this docs update! We review docs updates after the related code changes are approved, and merge when the code changes are released. I see that I labeled this "awaiting release", but the correct label is "awaiting review", which I have now set. We will be able to review this when the PR is finalized. Thanks!

I should be thanking you guys!
It's been a while since the last time I worked on this. I finally decided to get back on this, so I just fixed the comments in the related code PR. I hope we could merge this soon :)

Copy link
Contributor

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please close this as this is no longer supported.

@github-actions
Copy link

This pull request has been marked as stale because it has been open for 90 days with no activity. This pull request will be automatically closed in 30 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Nov 12, 2025
@TerryHowe
Copy link
Contributor

Reopen this if I missed something, thanks.

@TerryHowe TerryHowe closed this Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants