add --app-version flag to 'helm package' #3196
Conversation
|
Hey @adshmh! Thanks for the PR! It looks like CI failed on this PR. Would you mind fixing up the tests?
|
475df11 to
73aef75
Compare
|
@bacongobbler Thanks for the reminder. Fixed the doc issue. |
cmd/helm/package.go
Outdated
| debug("Setting version to %s", p.version) | ||
| } | ||
|
|
||
| if len(p.appVersion) != 0 { |
There was a problem hiding this comment.
it's probably simpler to just check if p.appVersion != "" instead of casting to an int.
There was a problem hiding this comment.
Thank you for the review. I have updated the PR.
|
one little change and it looks good to go! |
When 'helm package --app-version foo' is run, this will set the AppVersion field to 'foo' in the packaged chart. Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
73aef75 to
9e86970
Compare
|
On a similar note, it would be nice to have an --app-version flag for helm upgrade / helm install. |
Add the option 'app-version' to helm package command. When 'helm package --app-version foo' is run, this will set the AppVersion field to 'foo' in the packaged chart. Fixes #2566
Signed-off-by: Arash Deshmeh adeshmeh@ca.ibm.com