[v3 backport] fix(values): preserve nil values when chart default is empty map#31829
Merged
TerryHowe merged 6 commits intohelm:dev-v3from Feb 11, 2026
Merged
[v3 backport] fix(values): preserve nil values when chart default is empty map#31829TerryHowe merged 6 commits intohelm:dev-v3from
TerryHowe merged 6 commits intohelm:dev-v3from
Conversation
Only delete nil user values when overriding a non-nil chart default.
When chart has empty map or no default for a key, preserve user's nil.
| Scenario | Result |
|----------|--------|
| User sets `baz: ~`, chart has `baz: "value"` | Key deleted |
| User sets `baz: ~`, chart has empty map `{}` | Nil preserved |
| User sets `baz: ~`, chart has `baz: ~` | Nil preserved |
Fixes helm#31643
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
Co-authored-by: George Jenkins <gvjenkins@gmail.com> Signed-off-by: Evans Mungai <mbuevans@gmail.com>
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
TerryHowe
requested changes
Feb 11, 2026
Contributor
TerryHowe
left a comment
There was a problem hiding this comment.
Generally looks good, but your going to have to put this to the dev-v3 branch
Author
|
@TerryHowe I changed target branch to dev-v3 in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It is a backport of a fix for issue #31644
Special notes for your reviewer:
All commits from #31644 were back-ported 1 to 1 without any additional changes.
If applicable:
docs neededlabel should be applied if so)