Skip to content

Avoid panic in helm.sh/helm/v3/pkg/chartutil.ValidateAgainstSchema#31204

Merged
mattfarina merged 1 commit into
helm:mainfrom
benoittgt:fix-31202
Oct 22, 2025
Merged

Avoid panic in helm.sh/helm/v3/pkg/chartutil.ValidateAgainstSchema#31204
mattfarina merged 1 commit into
helm:mainfrom
benoittgt:fix-31202

Conversation

@benoittgt

@benoittgt benoittgt commented Aug 27, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Fixes: #31202

Special notes for your reviewer:

Do you confirm that this needs to be backported? I believe it does.

Also, please let me know if you think the approach is too defensive, or if we have included too many tests. :)

If applicable:

  • this PR contains user facing changes (the docs needed label should be applied if so)
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

@pull-request-size pull-request-size Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 27, 2025
Closes: helm#31202
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>

@TerryHowe TerryHowe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scottrigby scottrigby added the bug Categorizes issue or PR as related to a bug. label Sep 11, 2025
@gjenkins8 gjenkins8 added the Has One Approval This PR has one approval. It still needs a second approval to be merged. label Sep 25, 2025

@mattfarina mattfarina left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattfarina mattfarina merged commit 1da2b0a into helm:main Oct 22, 2025
5 checks passed
@scottrigby scottrigby removed the Has One Approval This PR has one approval. It still needs a second approval to be merged. label Oct 29, 2025
@scottrigby scottrigby added this to the 4.0.0 milestone Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panic in helm.sh/helm/v3/pkg/chartutil.ValidateAgainstSchema

5 participants