Added goreleaser instead of gox #30896 by Bhargavkonidena · Pull Request #30913 · helm/helm

Bhargavkonidena · 2025-05-26T07:17:36Z

Resolves #30896

Special notes for your reviewer:

If applicable:

this PR contains user facing changes (the docs needed label should be applied if so)
this PR contains unit tests
this PR has been tested for backwards compatibility

Signed-off-by: Bhargavkonidena <Bhargavkonidena@users.noreply.github.com>

Fix 30893

Signed-off-by: Bhargavkonidena <Bhargavkonidena@users.noreply.github.com>

gjenkins8

Thanks for the PR! I took an initial pass, I still need to review some of the specifics. But some initial comments:

Please don't remove .github/issue_template.md. That should be done in a separate and specific PR.
can we update the build-cross target in Makefile to also use goreleaser, and any related/then unused functionality e.g. TARGETS, TARGET_OBJS, GOX (and download), etc
- the test-acceptance target will need to be updated somehow. currently this only requires a build of linux/amd64. ideally we could emulate this logic

plus the comments inline on the PR. Thanks!

Signed-off-by: Bhargavkonidena <Bhargavkonidena@users.noreply.github.com>

Bhargavkonidena · 2025-05-29T05:12:08Z

Thanks for the PR! I took an initial pass, I still need to review some of the specifics. But some initial comments:

Please don't remove .github/issue_template.md. That should be done in a separate and specific PR.

can we update the build-cross target in Makefile to also use goreleaser, and any related/then unused functionality e.g. TARGETS, TARGET_OBJS, GOX (and download), etc

the test-acceptance target will need to be updated somehow. currently this only requires a build of linux/amd64. ideally we could emulate this logic

plus the comments inline on the PR. Thanks!

I am done with incorporating these review comments. Please check.

Bhargavkonidena · 2025-05-30T16:41:46Z

@gjenkins8 can you please review this PR

robertsirc · 2025-06-03T21:44:34Z

@mattfarina and I can review this on the next Helmternoon.

robertsirc

LGTM

gjenkins8

there are quite a few things to fix up here. once these are fixed, it is needed to test this change (as much as possible) locally. Then we can consider how to validate in github actions.

gjenkins8 · 2025-06-14T19:18:35Z

-	GOFLAGS="-trimpath" CGO_ENABLED=0 $(GOX) -parallel=3 -output="_dist/{{.OS}}-{{.Arch}}/$(BINNAME)" -osarch='$(TARGETS)' $(GOFLAGS) -tags '$(TAGS)' -ldflags '$(LDFLAGS)' ./cmd/helm
+build-cross:
+	@echo "==> Building cross-platform binaries using GoReleaser"
+	goreleaser build --clean --skip-validate --single-target


--skip-validate is deprecated -- see: https://goreleaser.com/deprecations/

don't you want/need to refer to the config file? And why is --single-target being passed here?

gjenkins8 · 2025-06-14T19:19:10Z

+
+.PHONY: build-linux-amd64
+build-linux-amd64:
+	GOOS=linux GOARCH=amd64 CGO_ENABLED=0 go build $(GOFLAGS) -trimpath -tags '$(TAGS)' -ldflags '$(LDFLAGS)' -o '$(BINDIR)/$(BINNAME)' ./cmd/helm


I think it would be better to use (for consistency) goreleaser w/ --single-target?

gjenkins8 · 2025-06-14T19:24:58Z

+      - linux
+      - darwin
+      - windows
+    goarch:


for GOARCH we previously had:

darwin/amd64 darwin/arm64 linux/amd64 linux/386 linux/arm linux/arm64 linux/ppc64le linux/s390x linux/riscv64 windows/amd64 windows/arm64

ie. linux/386, linux/arm, linux/ppc64le, linux/s390x linux/riscv64 need to continue to be built, but are missing here.

gjenkins8 · 2025-06-14T19:25:57Z

-          make build-cross VERSION="${{ github.ref_name }}"
-          make dist checksum VERSION="${{ github.ref_name }}"
+      - name: Run Go Release
+        uses: goreleaser/goreleaser-action@v6.3.0


we need to pin to a specific release via hash (see other uses:). Please also include the semver version as a comment.

gjenkins8 · 2025-06-14T19:26:08Z


-      - name: Build Helm Binaries
+      - name: Run Go Release
+        uses: goreleaser/goreleaser-action@v6.3.0


as above (we need to pin to a specific release via hash (see other uses:). Please also include the semver version as a comment.)

gjenkins8 · 2025-06-14T19:29:42Z

 .PHONY: test-acceptance
-test-acceptance: TARGETS = linux/amd64
-test-acceptance: build build-cross
+test-acceptance: build build-linux-amd64


test-acceptance previously built current arch + all architectures. Now it is building current + linux/amd64.

If I'm not mistaken, we previously did this to:

build all architectures to ensure all architectures build

build current arch, to run acceptable tests

We need to continue the above behavior here (rather than building current + linux/amd64 only; runners are most likely to be linux/amd64, which makes this redundant too)

gjenkins8 · 2025-06-14T19:34:40Z

-          make dist checksum VERSION="${{ github.ref_name }}"
+      - name: Run Go Release
+        uses: goreleaser/goreleaser-action@v6.3.0
+        if: success() && startsWith(github.ref, 'refs/tags/')


I this necessary? given https://github.com/helm/helm/pull/30913/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34L19

gjenkins8 · 2025-06-14T19:37:02Z

@@ -0,0 +1,38 @@
+project_name: helm


How are you testing this change? A superficial run fails with:

$ goreleaser build --clean --skip validate -f .github/workflows/.goreleaser.yaml • only version: 2 configuration files are supported, yours is version: 0 , please update your configuration ⨯ build failed after 0s error=only version: 2 configuration files are supported, yours is version: 0 , please update your configuration

gjenkins8 · 2025-06-14T19:39:30Z

+
+      - name: Verify checksum
+        run: |
+            make dist checksum VERSION="${{ github.ref_name }}"


unless I'm mistaken, make dist is recreating the release archives. Which .goreleaser.yaml is also configured to do:
https://github.com/helm/helm/pull/30913/files#diff-413d66267886290506ba7e2df00c65cb65341ec7347cd34568117ff435f63623R25

please use one or the other (preference would be to use goreleaser, rather than makefile logic I think)

gjenkins8 · 2025-06-14T19:44:41Z

+    ldflags:
+      - -s -w -extldflags "-static"
+    flags:
+      - -tags=netgo


where did this "netgo" tag come from?

The merge-base changed after approval.

github-actions · 2026-01-02T00:25:34Z

This pull request has been marked as stale because it has been open for 90 days with no activity. This pull request will be automatically closed in 30 days if no further activity occurs.

Bhargavkonidena added 10 commits May 26, 2025 10:56

Create bug.md

ab5084e

Signed-off-by: Bhargavkonidena <Bhargavkonidena@users.noreply.github.com>

Added issue templates for documentation & features

61e3139

Signed-off-by: Bhargavkonidena <Bhargavkonidena@users.noreply.github.com>

Delete .github/issue_template.md

fcef313

Signed-off-by: Bhargavkonidena <Bhargavkonidena@users.noreply.github.com>

Update and rename bug.md to bug-report.yaml

03d8e1e

Signed-off-by: Bhargavkonidena <Bhargavkonidena@users.noreply.github.com>

Update and rename feature.md to feature.yaml

ca89ae2

Signed-off-by: Bhargavkonidena <Bhargavkonidena@users.noreply.github.com>

Update and rename documentation.md to documentation.yaml

9431874

Signed-off-by: Bhargavkonidena <Bhargavkonidena@users.noreply.github.com>

Merge pull request #1 from Bhargavkonidena/fix_30893

1fe6dad

Fix 30893

Delete .github/ISSUE_TEMPLATE directory

ebce578

Signed-off-by: Bhargavkonidena <Bhargavkonidena@users.noreply.github.com>

Updated release.yml to include goreleaser

97edeb8

Signed-off-by: Bhargavkonidena <Bhargavkonidena@users.noreply.github.com>

Create .goreleaser.yaml

2790d8c

Signed-off-by: Bhargavkonidena <Bhargavkonidena@users.noreply.github.com>

Bhargavkonidena changed the title ~~Fix goreleaser~~ Added goreleaser instead of gox #30896 May 26, 2025

gjenkins8 reviewed May 28, 2025

View reviewed changes

Comment thread .github/workflows/release.yml Outdated

Comment thread .github/workflows/release.yml Outdated

Create issue_template.md

9582e56

Signed-off-by: Bhargavkonidena <Bhargavkonidena@users.noreply.github.com>

pull-request-size Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 29, 2025

Bhargavkonidena added 3 commits May 29, 2025 10:25

Update version 6.3.0 for goreleaser in release.yml

5fe7958

Signed-off-by: Bhargavkonidena <Bhargavkonidena@users.noreply.github.com>

Update version 6.3.0 for goreleaser in release.yml

8ac1459

Signed-off-by: Bhargavkonidena <Bhargavkonidena@users.noreply.github.com>

remove unwanted references

3af395c

Signed-off-by: Bhargavkonidena <Bhargavkonidena@users.noreply.github.com>

robertsirc added the v4.x Issues and Pull Requests related to the major version v4 label Jun 3, 2025

robertsirc previously approved these changes Jun 6, 2025

View reviewed changes

robertsirc added the Has One Approval This PR has one approval. It still needs a second approval to be merged. label Jun 6, 2025

gjenkins8 requested changes Jun 14, 2025

View reviewed changes

scottrigby added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 5, 2025

TerryHowe mentioned this pull request Sep 29, 2025

chore: replace mitchellh/gox with goreleaser #31343

Merged

3 tasks

gjenkins8 removed v4.x Issues and Pull Requests related to the major version v4 Has One Approval This PR has one approval. It still needs a second approval to be merged. labels Oct 3, 2025

github-actions Bot added the Stale label Jan 2, 2026

github-actions Bot closed this Feb 1, 2026

Conversation

Bhargavkonidena commented May 26, 2025

Uh oh!

gjenkins8 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Bhargavkonidena commented May 29, 2025

Uh oh!

Bhargavkonidena commented May 30, 2025

Uh oh!

robertsirc commented Jun 3, 2025

Uh oh!

robertsirc left a comment

Choose a reason for hiding this comment

Uh oh!

gjenkins8 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jan 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants