fix: copy dependencies on aliasing to avoid sharing chart references on multiply aliased dependencies [v3 backport]#30802
Conversation
imported values are stored in dependency objects, which breaks if a chart dependency is shared among multiple aliases. By copying the dependency objects in the metadata values can be imported correctly. Supersedes helm#10174 Signed-off-by: Daniel Strobusch <1847260+dastrobu@users.noreply.github.com>
ae7f176 to
bee2978
Compare
|
|
What is the new back-port strategy? I created the PR as a request for a back-port. |
|
Sorry @dastrobu I was not clear enough. I was referring to the last dev meeting where it was mentioned that backporting should be limited to bug and security fixes only. We will see with the code review, I'm probably wrong. :) |
|
It would be great to get this back ported. |
|
This pull request has been marked as stale because it has been open for 90 days with no activity. This pull request will be automatically closed in 30 days if no further activity occurs. |
|
We'd really appreciate this bug fix so we can remove our local fork of Helm. Is there anything the community can do to move this forward? |
|
@mattfarina @TerryHowe @AustinAbro321 @gjenkins8 @benoittgt, can one of you help move this PR forward? |
1 similar comment
|
@mattfarina @TerryHowe @AustinAbro321 @gjenkins8 @benoittgt, can one of you help move this PR forward? |
|
This pull request has been marked as stale because it has been open for 90 days with no activity. This pull request will be automatically closed in 30 days if no further activity occurs. |
This is a back port of #9175 as requested per #9175 (comment)
Dependencies keep a reference on their parent chart, which breaks if a chart reference is shared among multiple aliases.
By copying the dependencies, parent information can be set correctly to render the templates as expected later on.
Note that this change will make ChartFullPath return a different path for sub-subcharts. It will contain the alias names instead of the path to the chart files which makes it consistent with paths to templates on the subchart level.
Closes #9150
Signed-off-by: Daniel Strobusch 1847260+dastrobu@users.noreply.github.com
If applicable: