Skip to content

Bump text package with minimal impact#30745

Merged
robertsirc merged 1 commit intohelm:dev-v3from
benoittgt:testing-vuln
Apr 13, 2025
Merged

Bump text package with minimal impact#30745
robertsirc merged 1 commit intohelm:dev-v3from
benoittgt:testing-vuln

Conversation

@benoittgt
Copy link
Copy Markdown
Contributor

@benoittgt benoittgt commented Apr 11, 2025

What this PR does / why we need it:

This is a new attempt for #30729.

\cc @robertsirc

Close: #30729

Special notes for your reviewer:

If applicable:

  • this PR contains user facing changes (the docs needed label should be applied if so)
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 11, 2025
go.mod Outdated
github.com/redis/go-redis/extra/rediscmd/v9 v9.0.5 // indirect
github.com/redis/go-redis/extra/redisotel/v9 v9.0.5 // indirect
github.com/redis/go-redis/v9 v9.1.0 // indirect
github.com/redis/go-redis/v9 v9.6.3 // indirect
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion from #30742 (comment)

@benoittgt benoittgt changed the title Trigger build to check vuln Bump text package with minimal impact Apr 11, 2025
@benoittgt benoittgt mentioned this pull request Apr 11, 2025
3 tasks
@benoittgt benoittgt marked this pull request as ready for review April 11, 2025 13:56
Copy link
Copy Markdown
Member

@robertsirc robertsirc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsirc
Copy link
Copy Markdown
Member

I noticed this after i merged the other one you bumped up versions. Can you resolve this. I think we need to bring these up to the versions you had in #30742

@yxxhero yxxhero requested a review from Copilot April 12, 2025 04:28
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • go.mod: Language not supported

Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
Copy link
Copy Markdown
Contributor

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@miledxz
Copy link
Copy Markdown
Contributor

miledxz commented Apr 13, 2025

LGTM

@robertsirc robertsirc merged commit 0109c05 into helm:dev-v3 Apr 13, 2025
5 checks passed
@benoittgt benoittgt deleted the testing-vuln branch April 14, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants