Fix flaky TestDedupeRepos#30576
Merged
Merged
Conversation
639e730 to
93c94d9
Compare
gjenkins8
reviewed
Feb 23, 2025
gjenkins8
reviewed
Feb 23, 2025
gjenkins8
left a comment
Member
There was a problem hiding this comment.
Thanks for the speedy fix PR. One suggestion to use a helper from https://github.com/stretchr/testify?tab=readme-ov-file#assert-package
This is frequently used (including in other places in Helm) for unit tests in golang, to the point where it is close to being idiomatic (I'm sure some people would disagree with this statement)
gjenkins8
reviewed
Feb 23, 2025
gjenkins8
reviewed
Feb 23, 2025
Signed-off-by: Felipe Santos <felipecassiors@gmail.com>
19a42f5 to
0c645af
Compare
gjenkins8
approved these changes
Feb 23, 2025
Member
|
Merging size/XS with single review (minor test code fix only) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Closes #30573
Special notes for your reviewer:
Sorry, I'm not a golanger. The solution doesn't seem the cleanest, but it's the cleanest I could come up with. I'm open to suggestions.As suggested by @gjenkins8 here.