chore: Remove unused WaitAndGetCompletedPodPhase
#13665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TerryHowe
requested changes
Jan 28, 2025
cmd/helm/flags.go
Outdated
| } | ||
|
|
||
| func (p *postRendererString) Set(val string) error { | ||
| fmt.Println("set set", val) |
Contributor
There was a problem hiding this comment.
Suggested change
| fmt.Println("set set", val) |
Member
Author
There was a problem hiding this comment.
fail, debugging a different issue and changes got swept in. fixed now
cmd/helm/upgrade.go
Outdated
Comment on lines
105
to
106
| fmt.Println(P2) | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| fmt.Println(P2) |
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
0d3f9e0 to
d637595
Compare
mattfarina
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As noted in helm/community#374, this is unused (preemptively clean it up)
Special notes for your reviewer:
If applicable:
docs neededlabel should be applied if so)