Skip to content

Go 1.23 v3#13580

Merged
mattfarina merged 2 commits intohelm:dev-v3from
mattfarina:go-1.23-v3
Dec 30, 2024
Merged

Go 1.23 v3#13580
mattfarina merged 2 commits intohelm:dev-v3from
mattfarina:go-1.23-v3

Conversation

@mattfarina
Copy link
Copy Markdown
Collaborator

What this PR does / why we need it: The update to go is needed in order for #13555 to get into a state to be merged.

Special notes for your reviewer:

If applicable:

  • this PR contains user facing changes (the docs needed label should be applied if so)
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

Multiple changes were made to pass linting. Some Go built-in names
are being used for variables (e.g., min). This happens in the Go
source itself including the Go standard library and is not always
a bad practice.

To handle allowing some built-in names to be used the linter config
is updated to allow (via opt-in) some names to pass. This allows us
to still check for re-use of Go built-in names and opt-in to any
new uses.

There were also several cases where a value was checked for nil
before checking its length when this is already handled by len()
or the types default value. These were cleaned up.

The license validation was updated because it was checking everything
in the .git directory including all remote content that was local.
The previous vendor directory was from a time prior to Go modules
when Helm handled dependencies differently. It was no longer needed.

Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 5727f56)
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 66f84e5)
@mattfarina mattfarina added this to the 3.17.0 milestone Dec 28, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 28, 2024
@mattfarina mattfarina merged commit 2bfcedd into helm:dev-v3 Dec 30, 2024
@mattfarina mattfarina deleted the go-1.23-v3 branch December 30, 2024 00:02
@scottrigby
Copy link
Copy Markdown
Member

backport of #13546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants