Skip to content

Backport #13563 (fix testing on dev-v3 PRs)#13567

Merged
mattfarina merged 1 commit intohelm:dev-v3from
mattfarina:backport-fix-dev-v3-pr-tests
Dec 27, 2024
Merged

Backport #13563 (fix testing on dev-v3 PRs)#13567
mattfarina merged 1 commit intohelm:dev-v3from
mattfarina:backport-fix-dev-v3-pr-tests

Conversation

@mattfarina
Copy link
Copy Markdown
Collaborator

What this PR does / why we need it: tests are not running on PRs based on the dev-v3 branch. The change George made to the main branch appears to need to be backported to the dev-v3 branch. This cherry picks his commit to dev-v3.

Special notes for your reviewer:

If applicable:

  • this PR contains user facing changes (the docs needed label should be applied if so)
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 21, 2024
Copy link
Copy Markdown
Member

@robertsirc robertsirc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: George Jenkins <gvjenkins@gmail.com>
(cherry picked from commit bfada38)
@mattfarina mattfarina force-pushed the backport-fix-dev-v3-pr-tests branch from aef9131 to 2042f7d Compare December 26, 2024 21:39
@mattfarina
Copy link
Copy Markdown
Collaborator Author

@gjenkins8 or @robertsirc can you review this one again?

@mattfarina mattfarina merged commit 0a588c2 into helm:dev-v3 Dec 27, 2024
@mattfarina mattfarina deleted the backport-fix-dev-v3-pr-tests branch December 27, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants