Skip to content

Add annotations and dependencies to get metadata output#13343

Merged
gjenkins8 merged 1 commit intohelm:mainfrom
niladrih:more-metadata
Nov 19, 2024
Merged

Add annotations and dependencies to get metadata output#13343
gjenkins8 merged 1 commit intohelm:mainfrom
niladrih:more-metadata

Conversation

@niladrih
Copy link
Copy Markdown
Contributor

@niladrih niladrih commented Sep 19, 2024

Closes #12686

Sample outputs for empty annotations/dependencies..
TABLE:

CHART: foo
VERSION: 0.1.0-beta.1
APP_VERSION: 1.0
ANNOTATIONS: 
DEPENDENCIES: 
NAMESPACE: default
REVISION: 1
STATUS: deployed

YAML:

appVersion: 1.0
chart: foo
deployedAt: "2024-10-04T10:55:24+05:30"
name: foo
namespace: default
revision: 1
status: deployed
version: 0.1.0-beta.1

JSON:

{"name":"foo","chart":"foo","version":"0.1.0-beta.1","appVersion":"1.0","namespace":"default","revision":1,"status":"deployed","deployedAt":"2024-10-04T11:25:10+05:30"}

N.B.: The JSON and YAML outputs have omitempty

What this PR does / why we need it:
The output of helm get metadata includes a subset of the fields contained in the chart.Metadata struct. This change adds the values of the annotations field and the dependencies field to the output.

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 19, 2024
@niladrih niladrih requested a review from TerryHowe September 25, 2024 15:38
Copy link
Copy Markdown
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggested action

The output of helm get metadata includes a subset of the fields contained in
the chart.Metadata struct. This change adds the values of the annotations field
and the dependencies field to the output.

Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
Copy link
Copy Markdown
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsirc robertsirc added the Has One Approval This PR has one approval. It still needs a second approval to be merged. label Oct 7, 2024
@gjenkins8 gjenkins8 added this to the 3.17.0 milestone Oct 14, 2024
@gjenkins8 gjenkins8 added the Needs v3 backport Label PRs for v4/main, which are still applicable to v3 so need a separate backport PR label Nov 19, 2024
@gjenkins8 gjenkins8 merged commit c724175 into helm:main Nov 19, 2024
@mattfarina mattfarina added v3 port complete For completed v2->v3 ports and removed Needs v3 backport Label PRs for v4/main, which are still applicable to v3 so need a separate backport PR Has One Approval This PR has one approval. It still needs a second approval to be merged. labels Dec 30, 2024
@scottrigby scottrigby modified the milestones: 3.17.0, 4.0.0 Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature size/L Denotes a PR that changes 100-499 lines, ignoring generated files. v3 port complete For completed v2->v3 ports

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Helm get metadata command - info omitted

7 participants