Merged
Conversation
ef95d2e to
ff35d35
Compare
sundaram2021
left a comment
There was a problem hiding this comment.
Review
Dependency Updates:
Positive: Updating the Kubernetes Go dependencies ensures compatibility with newer versions of Kubernetes. The bump to v0.31.1 across various modules maintains consistency.
Impact: These updates should be tested to ensure that no breaking changes are introduced, especially in how the client-go and apimachinery handle API requests and responses.
Backward Compatibility:
Ensure that the updated versions maintain backward compatibility for older Kubernetes clusters that might still use previous versions.
Verification:
Since the changes are mainly dependency updates, it’s crucial to run the full suite of tests, especially those that involve Kubernetes interactions (e.g., using client-go or API machinery). Any new behavior or features in v0.31.1 should be confirmed to not break existing integrations.
Security:
Dependency bumps often fix security vulnerabilities. It's a positive move to keep the project up to date with secure dependencies.
70e4f4f to
5f93a88
Compare
Member
63af176 to
43cdcab
Compare
Bumps the k8s-io group with 7 updates: | Package | From | To | | --- | --- | --- | | [k8s.io/api](https://github.com/kubernetes/api) | `0.31.0` | `0.31.1` | | [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.31.0` | `0.31.1` | | [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.31.0` | `0.31.1` | | [k8s.io/apiserver](https://github.com/kubernetes/apiserver) | `0.31.0` | `0.31.1` | | [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime) | `0.31.0` | `0.31.1` | | [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.31.0` | `0.31.1` | | [k8s.io/kubectl](https://github.com/kubernetes/kubectl) | `0.31.0` | `0.31.1` | Updates `k8s.io/api` from 0.31.0 to 0.31.1 - [Commits](kubernetes/api@v0.31.0...v0.31.1) Updates `k8s.io/apiextensions-apiserver` from 0.31.0 to 0.31.1 - [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases) - [Commits](kubernetes/apiextensions-apiserver@v0.31.0...v0.31.1) Updates `k8s.io/apimachinery` from 0.31.0 to 0.31.1 - [Commits](kubernetes/apimachinery@v0.31.0...v0.31.1) Updates `k8s.io/apiserver` from 0.31.0 to 0.31.1 - [Commits](kubernetes/apiserver@v0.31.0...v0.31.1) Updates `k8s.io/cli-runtime` from 0.31.0 to 0.31.1 - [Commits](kubernetes/cli-runtime@v0.31.0...v0.31.1) Updates `k8s.io/client-go` from 0.31.0 to 0.31.1 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.31.0...v0.31.1) Updates `k8s.io/kubectl` from 0.31.0 to 0.31.1 - [Commits](kubernetes/kubectl@v0.31.0...v0.31.1) --- updated-dependencies: - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/apiextensions-apiserver dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/apiserver dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/cli-runtime dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/kubectl dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io ... Signed-off-by: dependabot[bot] <support@github.com>
43cdcab to
d5df067
Compare
mattfarina
approved these changes
Oct 4, 2024
robertsirc
approved these changes
Oct 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the k8s-io group with 7 updates:
0.31.00.31.10.31.00.31.10.31.00.31.10.31.00.31.10.31.00.31.10.31.00.31.10.31.00.31.1Updates
k8s.io/apifrom 0.31.0 to 0.31.1Commits
eb5129bUpdate dependencies to v0.31.1 tag46f6230Merge pull request #126761thockin/automated-cherry-pick-of-#1267491857695fix v1a3 ResourceSliceList metadata field nameUpdates
k8s.io/apiextensions-apiserverfrom 0.31.0 to 0.31.1Commits
b68c0ddUpdate dependencies to v0.31.1 tagUpdates
k8s.io/apimachineryfrom 0.31.0 to 0.31.1Commits
Updates
k8s.io/apiserverfrom 0.31.0 to 0.31.1Commits
0265ad6Update dependencies to v0.31.1 tag70ed6fdMerge pull request #126670liggitt/automated-cherry-pick-of-#12666531c2b5aRestore honoring --version build ID overridesUpdates
k8s.io/cli-runtimefrom 0.31.0 to 0.31.1Commits
754d15fUpdate dependencies to v0.31.1 tagUpdates
k8s.io/client-gofrom 0.31.0 to 0.31.1Commits
c5196ebUpdate dependencies to v0.31.1 tagUpdates
k8s.io/kubectlfrom 0.31.0 to 0.31.1Commits
0315be4Update dependencies to v0.31.1 tagDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions