Conversation
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
| go-version: '1.22' | ||
| check-latest: true |
There was a problem hiding this comment.
why not just use go-version-file: go.mod
There was a problem hiding this comment.
This is a good point. I can address that in another PR.
There was a problem hiding this comment.
The go directive in the go.mod file sets the minimum version of Go that can be used to compile the code. When we build Helm, we want to use the latest patch version on the minor version we are using. This way we get all of the bug and security fixes.
If Helm does use the go.mod file (either the go or toolchain directives) than we will need to update this file with every new Go release to ensure we build against the latest patch version of Go.
I'm not in favor of this extra work. If we went this way we would need to automate the updates to the go.mod file.
There was a problem hiding this comment.
I think with the change I made, it selects the latest version of whatever is specified in the go.mod file.
I am fixing the go setup to check for latest. Based on the docs here.
tested it with my actions and it resolves correctly:
Run actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 Setup go version spec 1.22 Attempting to resolve the latest version from the manifest... matching 1.22... Resolved as '1.22.[7](https://github.com/robertsirc/helm/actions/runs/10835235498/job/30066292590#step:3:8)'What this PR does / why we need it:
Special notes for your reviewer:
If applicable:
docs neededlabel should be applied if so)