Merged
Conversation
mattfarina
approved these changes
Sep 6, 2024
joejulian
reviewed
Sep 12, 2024
Signed-off-by: Nathan Baulch <nathan.baulch@gmail.com>
yardenshoham
approved these changes
Sep 23, 2024
TerryHowe
approved these changes
Sep 24, 2024
| } else { | ||
| // Create a long flag with the same name as the short flag. | ||
| // Not a perfect solution, but its better than ignoring the extra short flags. | ||
| // Not a perfect solution, but it's better than ignoring the extra short flags. |
Contributor
There was a problem hiding this comment.
I generally think it is better to avoid contractions
Contributor
Author
There was a problem hiding this comment.
I don't mind either way. The repo contains a mixture of both (21 instances of "it's") so I went with the simpler addition of an apostrophe.
mattfarina
approved these changes
Sep 27, 2024
Collaborator
mattfarina
left a comment
There was a problem hiding this comment.
@joejulian what do you think now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Just thought I'd contribute some typo fixes that I stumbled on. Nothing controversial (hopefully), just 23 simple fixes.
Use the following command to get a quick and dirty summary of the specific corrections made:
FWIW, the typos are: