Skip to content

Fix typos#13301

Merged
mattfarina merged 2 commits intohelm:mainfrom
NathanBaulch:typos
Sep 30, 2024
Merged

Fix typos#13301
mattfarina merged 2 commits intohelm:mainfrom
NathanBaulch:typos

Conversation

@NathanBaulch
Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Just thought I'd contribute some typo fixes that I stumbled on. Nothing controversial (hopefully), just 23 simple fixes.

Use the following command to get a quick and dirty summary of the specific corrections made:

git diff HEAD^! --word-diff-regex='\w+' -U0 \
  | grep -E '\[\-.*\-\]\{\+.*\+\}' \
  | sed -r 's/.*\[\-(.*)\-\]\{\+(.*)\+\}.*/\1 \2/' \
  | sort | uniq -c | sort -n

FWIW, the typos are:

  • lenght (4)
  • suplied (4)
  • alwaty (2)
  • chechk (1)
  • addes (1)
  • appliyed (1)
  • assigment (1)
  • automattic (1)
  • complient (1)
  • cosumed (1)
  • exists (1)
  • friendy (1)
  • partioned (1)
  • suberesource (1)
  • supercede (1)
  • unparseable (1)

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 5, 2024
@mattfarina mattfarina added the Has One Approval This PR has one approval. It still needs a second approval to be merged. label Sep 6, 2024
Copy link
Copy Markdown
Member

@robertsirc robertsirc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 12, 2024
Signed-off-by: Nathan Baulch <nathan.baulch@gmail.com>
Signed-off-by: Nathan Baulch <nathan.baulch@gmail.com>
Copy link
Copy Markdown
Contributor

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

} else {
// Create a long flag with the same name as the short flag.
// Not a perfect solution, but its better than ignoring the extra short flags.
// Not a perfect solution, but it's better than ignoring the extra short flags.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally think it is better to avoid contractions

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind either way. The repo contains a mixture of both (21 instances of "it's") so I went with the simpler addition of an apostrophe.

Copy link
Copy Markdown
Collaborator

@mattfarina mattfarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joejulian what do you think now?

Copy link
Copy Markdown
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattfarina mattfarina merged commit eecb848 into helm:main Sep 30, 2024
@mattfarina mattfarina added this to the 3.16.2 milestone Sep 30, 2024
@NathanBaulch NathanBaulch deleted the typos branch September 30, 2024 21:32
@mattfarina mattfarina added the picked Indicates that a PR has been cherry-picked into the next release candidate. label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Has One Approval This PR has one approval. It still needs a second approval to be merged. picked Indicates that a PR has been cherry-picked into the next release candidate. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants