Skip to content

Improves handling of Helm index with broken helm chart versions #13176#13177

Merged
mattfarina merged 3 commits intohelm:mainfrom
bb-Ricardo:main
Oct 4, 2024
Merged

Improves handling of Helm index with broken helm chart versions #13176#13177
mattfarina merged 3 commits intohelm:mainfrom
bb-Ricardo:main

Conversation

@bb-Ricardo
Copy link
Copy Markdown
Contributor

@bb-Ricardo bb-Ricardo commented Jul 12, 2024 •
edited
Loading

What this PR does / why we need it:
See issue #13176

Special notes for your reviewer:

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

closes #13176

@bb-Ricardo
improves handling of Helm index with broken helm chart versions helm#…
154b477 
…13176

Signed-off-by: ricardo.bartels@telekom.de <ricardo.bartels@telekom.de>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 12, 2024
@bb-Ricardo
adds tests for handling of Helm index with broken chart versions helm…
af13b0d 
…#13176

Signed-off-by: ricardo.bartels@telekom.de <ricardo.bartels@telekom.de>
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 14, 2024
@bb-Ricardo
Copy link
Copy Markdown
Contributor Author

bb-Ricardo commented Jul 14, 2024

Added the missing tests.

@gjenkins8 gjenkins8 mentioned this pull request Jul 26, 2024
Closed
gjenkins8
gjenkins8 reviewed Jul 26, 2024
View reviewed changes
@gjenkins8 gjenkins8 added the bug Categorizes issue or PR as related to a bug. label Aug 7, 2024
gjenkins8
gjenkins8 requested changes Aug 7, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@gjenkins8 gjenkins8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/helm/helm/pull/13177/files#r1693820690

@bb-Ricardo
Copy link
Copy Markdown
Contributor Author

bb-Ricardo commented Aug 7, 2024

Still out of town, back next week.

@gjenkins8 gjenkins8 added this to the 3.16.2 milestone Sep 16, 2024
@gjenkins8 gjenkins8 added the Has One Approval This PR has one approval. It still needs a second approval to be merged. label Sep 29, 2024
@robertsirc robertsirc changed the title improves handling of Helm index with broken helm chart versions #13176 Improves handling of Helm index with broken helm chart versions #13176 Oct 4, 2024
@bb-Ricardo @robertsirc
Revering change unrelated to issue helm#13176
cdbef2b 
Signed-off-by: ricardo.bartels@telekom.de <ricardo.bartels@telekom.de>
@mattfarina
Copy link
Copy Markdown
Collaborator

mattfarina commented Oct 4, 2024

Note, the force push was to make CI run so the checks passed. No code was changed by the maintainers.

@mattfarina mattfarina merged commit 145d12f into helm:main Oct 4, 2024
@mattfarina mattfarina added the picked Indicates that a PR has been cherry-picked into the next release candidate. label Oct 9, 2024
@astraldawn astraldawn mentioned this pull request Nov 1, 2024
Closed
@atombrella atombrella mentioned this pull request Nov 22, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattfarina mattfarina mattfarina approved these changes

@gjenkins8 gjenkins8 gjenkins8 approved these changes

Assignees

No one assigned

Labels

bug Categorizes issue or PR as related to a bug. Has One Approval This PR has one approval. It still needs a second approval to be merged. picked Indicates that a PR has been cherry-picked into the next release candidate. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

3.16.2

Development

Successfully merging this pull request may close these issues.

improve handling of Helm index with broken helm chart versions

3 participants

@bb-Ricardo @mattfarina @gjenkins8