Fix: Ignore alias validation error for index load#12789
Merged
mattfarina merged 2 commits intohelm:mainfrom Feb 19, 2024
Merged
Fix: Ignore alias validation error for index load#12789mattfarina merged 2 commits intohelm:mainfrom
mattfarina merged 2 commits intohelm:mainfrom
Conversation
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
mattfarina
approved these changes
Feb 8, 2024
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
sabre1041
approved these changes
Feb 15, 2024
Contributor
sabre1041
left a comment
There was a problem hiding this comment.
LGTM. Confirmed contents of PR addresses error as described in this issue
mattfarina
approved these changes
Feb 19, 2024
14 tasks
|
I see milestone was set to 3.14.2, but it was not released yet, right? |
Milestone 3.14.2 is scheduled to be released by March 13, 2024. https://github.com/helm/helm/milestone/138 |
Then what is this https://github.com/helm/helm/releases/tag/v3.14.2? 🧐 |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR skips the alias validation error introduced in #9176 when loading chart indexes.
fixes: #12735
fixes: #12748
Special notes for your reviewer:
Checking the error type and string is super brittle. And IMHO super hacky. Happy for other suggestions. Without introducing a full "chart validation" type/interface, I didn't really see another (easy) option :(. But I do think we should attempt to not revert #9176 .
If applicable: