pkg/chartmuseum,cmd: introduce the new keep-chart-always-up-to-date flag and the default cache interval when not set.
#593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dea15fe to
44034ff
Compare
cbuto
reviewed
Jun 6, 2022
739b0a7 to
7b02ed0
Compare
Contributor
|
looks like there is a new data race |
cbuto
reviewed
Jun 15, 2022
Contributor
Author
Yes , I will try to resolve it |
810daba to
e029f4c
Compare
… flag and the default cache interval when not set. * The flags works to always get the realtime index for the chart repository(which is the behavior before v0.13.0), it will cost more fs I/O. * Default interval is now set to 5m when `cache-interval` flag not set which we suggests in the issue list. The patch includes: * increases most of the museum api throughout by wrapping the event emitter into goroutine since the event listener already holds on the concurrent lock(#396). * adds the new server option `keep-chart-always-up-to-date` to force use the latest version. * `getIndexFile` rollbacks to fully reload index only if cacheinterval not set for better backward compatibility before v0.13.0(#444). Signed-off-by: scnace <scbizu@gmail.com> Signed-off-by: scbizu <scbizu@gmail.com>
…index refresher works. Signed-off-by: scbizu <scbizu@gmail.com>
Signed-off-by: scbizu <scbizu@gmail.com>
123cf9f to
d8e389d
Compare
Contributor
Author
|
Seems like resolved it , so many lock tricks XD PTAL @cbuto |
cbuto
reviewed
Jun 21, 2022
cmd/chartmuseum/main.go
Outdated
| PerChartLimit: conf.GetInt("per-chart-limit"), | ||
| WebTemplatePath: conf.GetString("web-template-path"), | ||
| ArtifactHubRepoID: conf.GetStringMapString("artifact-hub-repo-id"), | ||
| AlwaysRegenerateIndex: conf.GetBool("always-regenerate-index"), |
Contributor
There was a problem hiding this comment.
to make sure this matches the flag name in pkg/config/vars.go
Suggested change
| AlwaysRegenerateIndex: conf.GetBool("always-regenerate-index"), | |
| AlwaysRegenerateIndex: conf.GetBool("always-regenerate-chart-index"), |
Contributor
|
nice @scbizu! looks good aside from the one comment. is it worth running a quick loadtest locally to compare main vs these changes (mainly the new locks)? |
Contributor
Author
|
@cbuto Sorry for my low local machine setup , I need your help for the loadtest xD |
Contributor
no problem! I'll try to get some time to run a few and post the results |
Contributor
|
I ran three tests:
Overall it seems like these changes without the flag set shouldn't have any affect, but setting this flags introduces a ton of latency, which I think is expected.
|
Contributor
Author
|
I think so , thank you @cbuto |
cbuto
approved these changes
Jun 24, 2022
Contributor
cbuto
left a comment
There was a problem hiding this comment.
Lgtm! We’ll just need to address the flag name issue in the other comment
|
Really eager to see this fix merged in :) The PR has been reviewed, does it need to also wait for @jdolitsky to review? |
Contributor
Author
|
It would be better to be so , and I think cbuto and me also can handle it and make the canary(main) release , thoughts @cbuto ? |
Contributor
|
@scbizu I'd be good with merging this after #593 (comment) is resolved! |
Contributor
Author
|
okay , I will resolve it soon ~ |
Co-authored-by: Casey Buto <cbuto@d2iq.com> Signed-off-by: Nace Sc <scbizu@icloud.com> Signed-off-by: scbizu <scbizu@gmail.com>
d8e389d to
a1cefb9
Compare
Contributor
Author
|
Solved |
cbuto
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #444
cache-intervalflag not set which we suggests in the issue list.Signed-off-by: scnace scbizu@gmail.com