Skip to content

feat: Add support for hosting an artifacthub-repo.yml file #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cbuto merged 3 commits into from
May 31, 2022
Merged

feat: Add support for hosting an artifacthub-repo.yml file #579

cbuto merged 3 commits into from
May 31, 2022

Conversation

@cbuto
Copy link
Contributor

@cbuto cbuto commented Apr 28, 2022 •
edited
Loading

Fixes #419.

This is an initial take at hosting an artifacthub-repo.yml from ChartMuseum.

Currently, it will only support setting the repositoryID in the artifacthub-repo.yml file, but adding more fields in the future shouldn't be too difficult.

Let me know what you think, especially the CLI flag implementation for multitenancy.

@cbuto cbuto self-assigned this Apr 28, 2022
@cbuto cbuto force-pushed the feat/artifacthub branch from 791635d to ef22679 Compare April 28, 2022 22:25
@cbuto cbuto added this to the v0.15.0 milestone May 16, 2022
@cbuto cbuto force-pushed the feat/artifacthub branch 2 times, most recently from fa90796 to 7b9e8e9 Compare May 25, 2022 22:00
scbizu
scbizu reviewed May 26, 2022
View reviewed changes
@scbizu
Copy link
Contributor

scbizu commented May 26, 2022 •
edited
Loading

For me , I can accept the flag set mechanism for multi-tenancy but it maybe hard to set those flags if users have a large set of tenancy , any thoughts about the stdin (i.e.: json file stdin) ?

cbuto added 3 commits May 26, 2022 10:04
@cbuto
feat: Add support for hosting an artifacthub-repo.yml file
f1563b2 
Signed-off-by: Casey Buto <cbuto@d2iq.com>
@cbuto
feat: Add multitenancy support for artifacthub
26535d4 
Signed-off-by: Casey Buto <cbuto@d2iq.com>
@cbuto
refactor: check if map is empty before adding the route
96cdf35 
Signed-off-by: Casey Buto <cbuto@d2iq.com>
@cbuto cbuto force-pushed the feat/artifacthub branch from c997f0d to 96cdf35 Compare May 26, 2022 14:04
@cbuto
Copy link
Contributor Author

cbuto commented May 26, 2022

For me , I can accept the flag set mechanism for multi-tenancy but it maybe hard to set those flags if users have a large set of tenancy , any thoughts about the stdin (i.e.: json file stdin) ?

yeah it definitely could be cumbersome to set all the flags. Reading a json file could work but that feels cumbersome for cases where users only use depth=0 or a small number of repos 🤔. Maybe supporting a combination of the two could be implemented in the future once we get some feedback?

@scbizu
Copy link
Contributor

scbizu commented May 27, 2022

Maybe supporting a combination of the two could be implemented

Yeah , I mean that .

jdolitsky
jdolitsky approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@jdolitsky jdolitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@cbuto cbuto merged commit 68771af into helm:main May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdolitsky jdolitsky jdolitsky approved these changes

@scbizu scbizu scbizu approved these changes

@nerdeveloper nerdeveloper Awaiting requested review from nerdeveloper

Assignees

@cbuto cbuto

Labels

size/L

Projects

None yet

Milestone

v0.15.0

Development

Successfully merging this pull request may close these issues.

How to upload meta file artifacthub-repo.yml?

3 participants

@cbuto @scbizu @jdolitsky