-
Notifications
You must be signed in to change notification settings - Fork 409
feat: customize welcome page #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! 🎉
Looks good for the most part, I did note one issue around auth that we'll have to figure out.
cbuto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for fixing the auth! I think this should be good to go once some basic unit tests are updated/added to cover this new feature. Thanks!!
e1fc6a0 to
93d4633
Compare
|
Hi @cbuto, add the tests and removed the folder with the example html files. The Readme has the new feature explained. Looking for your feedback :) |
cbuto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! thanks for adding the tests!
maybe we can get one more review @nerdeveloper @scbizu?
scbizu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM , adds some small code suggestions.
|
HI @scbizu, thanks for the input. I changed the parts! Looking forward for your fedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dirien Need some more small changes here XD
|
@scbizu done. moved the error check above the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dirien add some error log is better ?
Signed-off-by: Engin Diri <engin.diri@mail.schwarz>
|
LGTM , merged . |
|
Thanks for working on this @dirien! 🎉 |
Fixes: #550
Hi,
this PR enables potential users to provide their own Welcome page.
With the flag
--web-template-path=<path>, you can specify the path to your custom welcome page.The structure of the folder should be like this:
web/ index.html xyz.html static/ main.css main.jsI use
c.HTMLto serve the custom welcome page, this means we have full access to the go-template engineThe rules are: Every file with html ending will be picked up. This is useful if you want to create templates and include them in the main index.html file (see my example). But only the
index.htmlwill be served!Static files (css, js or pics) should be saved into the
staticfolder. I check the code, if the static folder if present to serve this.If everybody like this, I will extend the enable the helm chart too.
Example:

Looking for your feedback!