feature add chart template and value api #551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zerohzz <zzhzero@qq.com>
Signed-off-by: zerohzz <zzhzero@qq.com>
Contributor
|
The PR relates to #509 ? |
cbuto
reviewed
Feb 15, 2022
Contributor
cbuto
left a comment
There was a problem hiding this comment.
few small nits around style
Signed-off-by: zerohzz <zzhzero@qq.com>
scbizu
requested changes
Feb 23, 2022
Contributor
|
Another question , should this new handler be protected with the auth mechanism? /cc @cbuto |
Contributor
|
@scbizu we definitely need auth for these endpoints if they aren't already covered 👀 but it looks like it is. |
Signed-off-by: zzhzero <zzhzero@qq.com>
Contributor
|
want to give it another look @scbizu? |
scbizu
approved these changes
Apr 7, 2022
Contributor
|
LGTM , let me do the re-format things , thank you @zzhzero 🎉 |
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.