Skip to content

Conversation

@marcoklaassen
Copy link
Contributor

@marcoklaassen marcoklaassen commented Oct 27, 2020

JMESPath Support

Not every JWT token provider is able to define the token the way the chartmuseum wants it.
In my case, my sso produces e.g.:

"resource_access": {
    "chartmuseum": {
      "roles": [
        "pull"
      ]
    }
  },

If you are not able to configure the JWT token provider yourself, i think it is a good idea to provide a solution by the chartmuseum.

With JMESPath Support we can make the path to find the allowed actions configurable.
To avoid a breaking change, i defined a default JMESPath in the auth module. This default configuration does the same job as the old implementation.

The pull request for the auth repository: chartmuseum/auth#10

@thelinuxfoundation
Copy link

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

@thelinuxfoundation
Copy link

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

@thelinuxfoundation
Copy link

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

Signed-off-by: Marco Klaassen <klaassen.marco@googlemail.com>
@thelinuxfoundation
Copy link

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

@jdolitsky
Copy link
Contributor

Cool feature, thank you. Putting this into a v0.14 milestone since we are behind on getting v0.13 out

@jdolitsky jdolitsky added this to the v0.14.0 milestone Nov 12, 2020
@jdolitsky jdolitsky removed the v0.14.0 label Nov 12, 2020
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
@jdolitsky
Copy link
Contributor

@marcoklaassen - thanks for you patience with this, merged

@jdolitsky jdolitsky merged commit 8ebb204 into helm:main Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants