Allow to bind chartmuseum to a specific interface #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
74997b3 to
bebe72c
Compare
The new config option "listen.host" ("--listen-host", "LISTEN_HOST") may
be used to bind chartmuseum to a specific interface rather than 0.0.0.0.
Default is 0.0.0.0 to stick with current behaviour.
Fixes helm#255
Signed-off-by: jayme-github <jayme-github@users.noreply.github.com>
bebe72c to
91088c5
Compare
jdolitsky
requested changes
Jul 14, 2020
Contributor
jdolitsky
left a comment
There was a problem hiding this comment.
@jayme-github thanks for opening-
Can we modify to make this a field on the router, so that we do not need to modify the signature of router.Start or server.Listen?
Signed-off-by: jayme-github <jayme-github@users.noreply.github.com>
f18ed1f to
abd791c
Compare
Contributor
Author
Sure, let me know that you think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new config option "listen.host" ("--listen-host", "LISTEN_HOST") may
be used to bind chartmuseum to a specific interface rather than 0.0.0.0.
Default is 0.0.0.0 to stick with current behaviour.
Fixes #255