Remove redundant type conversion #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdolitsky
requested changes
May 14, 2020
Contributor
jdolitsky
left a comment
There was a problem hiding this comment.
Looks good! 1 small comment
cmd/chartmuseum/main.go
Outdated
| "helm.sh/chartmuseum/pkg/chartmuseum" | ||
| "helm.sh/chartmuseum/pkg/config" | ||
|
|
||
| "github.com/chartmuseum/storage" |
Contributor
There was a problem hiding this comment.
Can we put this import back w/ the other chartmuseum ones?
Contributor
Author
There was a problem hiding this comment.
Do you mean mixing imports from helm.sh/chartmuseum and github.com/chartmuseum?
Signed-off-by: hezhizhen <hezhizhen.yi@gmail.com>
Contributor
Author
|
@jdolitsky How do you group imports? I didn't find anything about it. |
Contributor
|
@hezhizhen - actually you're right, should be how you had it.. Dont have a documented process, just trying to follow same process in all files. I will go ahead and merge though, its not a big deal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.