Fix helm-extra-set-args in YAML configuration
#713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b430659 to
c57e911
Compare
ryan-surname-p
approved these changes
Feb 8, 2025
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Contributor
Author
|
Can we unstale this? It's still needed. |
Contributor
Author
|
@unguiculus Is it possible to get this fix in, please? |
Contributor
|
+1 on this fix |
Member
|
@arbourd can you rebase? |
Currently, `helm-extra-set-args` is only available as a command-line flag, despite being part of the config object. This does not appear to be documented. This changes sources the value `extraSetArgs` via the `config` object rather than the cmd.Flags() only. Signed-off-by: Dylan Arbour <arbourd@users.noreply.github.com>
c57e911 to
97d7b06
Compare
Contributor
Author
|
@cpanato Done. |
Contributor
Author
|
No, thank you! Appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allows the usage of
helm-extra-set-argskey from act.yamland not just command-line flags.Currently,
helm-extra-set-argsis only available as a command-line flag, despite being part of the config object. This does not appear to be documented.This change sources the value
extraSetArgsvia theconfigobject rather than the cmd.Flags() only.This PR adds the configuration option but it is never used: #697