Skip to content

[Feature Request] target-branch default should fallback to main from master (or visa versa) #376

@spkane

Description

@spkane

Is this a request for help?: No


Is this a BUG REPORT or FEATURE REQUEST? (choose one): FEATURE REQUEST

Version of Helm and Kubernetes:

version.BuildInfo{Version:"v3.7.2", GitCommit:"663a896f4a815053445eec4153677ddc24a0a361", GitTreeState:"clean", GoVersion:"go1.17.3"}

Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.1", GitCommit:"86ec240af8cbd1b60bcc4c03c20da9b98005b92e", GitTreeState:"clean", BuildDate:"2021-12-16T11:33:37Z", GoVersion:"go1.17.5", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.4", GitCommit:"b695d79d4f967c403a96986f1750a35eb75e75f1", GitTreeState:"clean", BuildDate:"2021-11-17T15:42:41Z", GoVersion:"go1.16.10", Compiler:"gc", Platform:"linux/amd64"}

Version: 3.5.0
Git commit: e97261b
Date: 2022-01-06
License: Apache 2.0

What happened:

$ ct list-changed
Error: Error running process: exit status 128
Error running process: exit status 128

What you expected to happen:

I expected it to work, or provide a useful error message.

How to reproduce it (as minimally and precisely as possible):

Create a new git repo that uses main instead of master as its default branch, and has no master branch.
Commit a helm chart into the main branch
Create a branch and modify the helm chart and then commit it to your branch.

Run:

$ ct list-changed
Error: Error running process: exit status 128
Error running process: exit status 128

Anything else we need to know:

A descriptive error message would be a big improvement, but it would also be nice if the tool actually used main as the default target branch, and if it gets an error finding that branch, it falls back to trying master before finally giving the user an error that "the default branch (main or master) can not be found. Please provide the correct target-branch with --target-branch"

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions