-
Notifications
You must be signed in to change notification settings - Fork 246
Description
Version of Helm and Kubernetes:
helm version: v3.4.0
kubectl version: v1.20.2
ct version: helm/chart-testing-action@v2.0.1
What happened:
When using ct install with --helm-extra-args --set the uninstall of the helm chart gives an error.
helm uninstall helm-chart --namespace default --set key=value
Error: Error installing charts: Error processing charts
Error: unknown flag: --set
Error deleting Helm release: Error waiting for process: exit status 1
What you expected to happen:
The expectation was that the helm chart could be uninstalled correctly.
How to reproduce it (as minimally and precisely as possible):
Use ct install with an --helm-extra-args that is not available in the helm uninstall command but can be used in helm install.
Anything else we need to know:
I guess the issue is because the same variable is used in the following code snippets:
Uninstall:
chart-testing/pkg/tool/helm.go
Line 81 in e84e88c
| if err := h.exec.RunProcess("helm", "uninstall", release, "--namespace", namespace, h.extraArgs); err != nil { |
Install/Upgrade:
chart-testing/pkg/tool/helm.go
Line 58 in e84e88c
| if err := h.exec.RunProcess("helm", "install", release, chart, "--namespace", namespace, |
chart-testing/pkg/tool/helm.go
Line 67 in e84e88c
| if err := h.exec.RunProcess("helm", "upgrade", release, chart, "--namespace", namespace, |