Skip to content
This repository was archived by the owner on Mar 5, 2024. It is now read-only.

Adapt cli commands for rebar 3.14#743

Merged
evanmcc merged 6 commits intomasterfrom
adt/rebar3.14
Apr 21, 2021
Merged

Adapt cli commands for rebar 3.14#743
evanmcc merged 6 commits intomasterfrom
adt/rebar3.14

Conversation

@Vagabond
Copy link
Copy Markdown
Contributor

@Vagabond Vagabond commented Feb 24, 2021

Related to helium/miner#567

@Vagabond Vagabond requested a review from evanmcc February 24, 2021 17:03
@Vagabond
Copy link
Copy Markdown
Contributor Author

Vagabond commented Feb 24, 2021

One problem here is all the command outputs now ends with the line ok which breaks some scripts that expect the output on a single line.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 24, 2021 •
edited
Loading

Codecov Report

Merging #743 (d78bb06) into master (089fc91) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #743   +/-   ##
=======================================
  Coverage   71.66%   71.66%           
=======================================
  Files          97       97           
  Lines       13798    13798           
=======================================
  Hits         9889     9889           
  Misses       3909     3909
Impacted Files Coverage Δ
src/handlers/blockchain_sync_handler.erl 92.85% <0.00%> (-1.79%) ⬇️
src/ledger/v1/blockchain_ledger_v1.erl 80.77% <0.00%> (-0.11%) ⬇️
src/blockchain_worker.erl 36.65% <0.00%> (+0.24%) ⬆️
src/transactions/blockchain_txn_mgr.erl 55.04% <0.00%> (+0.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 089fc91...d78bb06. Read the comment docs.

@Vagabond
Copy link
Copy Markdown
Contributor Author

Vagabond commented Feb 25, 2021

This depends on erlware/relx#855

@Vagabond
Copy link
Copy Markdown
Contributor Author

Vagabond commented Feb 25, 2021

Additionally this branch works with OTP 24

@Vagabond Vagabond mentioned this pull request Feb 25, 2021
Merged
jadeallenx
jadeallenx approved these changes Apr 19, 2021
View reviewed changes
src/cli/blockchain_console.erl
clique:run(Cmd).
%% this is the contents of clique:run but
%% we want to figure out if the command worked
%% or not
Copy link
Copy Markdown
Contributor

@jadeallenx jadeallenx Apr 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok for now but seems like it ought to be a new function in clique run_and_return_status/1 or something...

Copy link
Copy Markdown
Contributor Author

@Vagabond Vagabond Apr 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we should make an upstream PR

@evanmcc evanmcc merged commit 7e196de into master Apr 21, 2021
@evanmcc evanmcc deleted the adt/rebar3.14 branch April 21, 2021 22:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@evanmcc evanmcc evanmcc approved these changes

@jadeallenx jadeallenx jadeallenx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Vagabond @evanmcc @jadeallenx