Keith HIPs (3 in total)#680
Closed
KeithRettig wants to merge 34 commits intohelium:mainfrom
KeithRettig:main
Closed
Keith HIPs (3 in total)#680KeithRettig wants to merge 34 commits intohelium:mainfrom KeithRettig:main
KeithRettig wants to merge 34 commits intohelium:mainfrom
KeithRettig:main
Conversation
This HIP proposes to make modifications to how Service Providers are eligible for rewards from the Service Provider MOBILE Reward bucket.
I suppose this should go to the discussion section?
I hope I am doing this right. I do not know how to put a table around the lines 13-20; please help if you are willing.
Updated title based on what you did to my other submission.
I am worried I am introducing versioning issues.
Create HIP nn: Set a Minimum Device Onboarding Fee
…inimum Device Onboarding Fees
added the math symbols and table edits
…P XX: Proportional Service Provider Rewards
…onal-Service-Provider-Rewards I think I have all your edit requests done.
…imum-Device-Onboarding-Fees I hope I am doing this right Valerie!
…ouble-the-Value-of-Helium-Data-Credits file name change, some typos, and an attempt to avoid edit requests from Valerie (as per requested changes to another HIP).
Keith rettig patch 2
original draft that was later forked.
…l-service-provider-rewards Just noticed that preferred filename format is to have all lower case.
…m-device-onboarding-fees Just noticed that preferred filename format is to have all lower case.
…e-value-of-helium-data-credits Just noticed that preferred filename format is to have all lower case.
added stricter punishment for not paying the onboard fees by end of grace period.
This comment was marked as spam.
This comment was marked as spam.
vincenzospaghetti
suggested changes
May 30, 2023
| @@ -0,0 +1,113 @@ | |||
| # HIP XX: Lower Minimum Device Onboarding Fees | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
There was a problem hiding this comment.
Adding why it is believed that the slight modifications to HIP81 should allow the HIP to pass. I am of the position that the problems being addressed are already part of the content. They are addressing exactly the same issue.
Changes made per Valerie's request.
Contributor
Author
|
I hope I am doing this correctly. I think you might want to do this one before you work on the pull request for the changes to the Double-the-value HIP submission. |
Contributor
Author
|
Some quick edits requested by the group as a result of discussing with capcom. |
Contributor
Author
|
@abhay ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I apologize about this. I didn't realize that it was better to keep HIPs separated into different branches. Here are all three of my HIPs. They have been edited and formatted to my understanding of how Valerie wants it (as per some editing requests earlier). I think this pull request will in effect create a second HIP for Service Provider Rewards. The versions of all three HIPs in this pull request are the most up-to-date.