HIP-xxxx: Payment Notes#117
Merged
jamiew merged 6 commits intohelium:masterfrom Jan 29, 2021
cvolkernick:cvolkernick/payment-notes
Merged
HIP-xxxx: Payment Notes#117jamiew merged 6 commits intohelium:masterfrom cvolkernick:cvolkernick/payment-notes
jamiew merged 6 commits intohelium:masterfrom
cvolkernick:cvolkernick/payment-notes
Conversation
Contributor
|
Will review this evening and let you know if any changes needed prior to merging |
Contributor
Author
|
Thanks @jamiew you the real MVP |
Contributor
|
Couple thoughts here:
|
Contributor
|
Looks good enough to merge for discussion. Stand by for tracking issue |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal I've watched get knocked around the discord in various forms for awhile now. Figured I'd make it an official proposal and gather feedback from the community.