chore: gitignore UI node_modules and .svelte-kit build artifacts#110
Open
marksverdhei wants to merge 1 commit into
Open
chore: gitignore UI node_modules and .svelte-kit build artifacts#110marksverdhei wants to merge 1 commit into
marksverdhei wants to merge 1 commit into
Conversation
The tools/ui and legacy tools/server/webui workspaces leave machine-local npm/SvelteKit output (node_modules/, .svelte-kit/) untracked in the working tree. These are regenerated by npm and never committed — the UI ships as prebuilt assets fetched by scripts/ui-assets.cmake — but with no ignore rule they show up in `git status` and pollute grep/ripgrep over the repo. Add `node_modules/` and `.svelte-kit/` ignore rules. No tracked files match either pattern, so nothing is removed from version control.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
tools/uiand legacytools/server/webuiworkspaces leave machine-local npm / SvelteKit output untracked in the working tree:These are regenerated by
npmand never committed — the UI ships as prebuilt assets fetched byscripts/ui-assets.cmake— but with no ignore rule they sit ingit statusand pollutegrep/rgsweeps over the repo (e.g. a recentgrepfor jinja symbols got swamped by.svelte-kit/output/clientbundles).Change
Add
node_modules/and.svelte-kit/to.gitignore(under the existing "Server Web UI temporary files" section).Safety
git check-ignoreconfirms all three dirs are now ignored.git ls-files | grep -E 'node_modules/|\.svelte-kit/'→ none tracked, so nothing is removed from version control.