fix(tests): test-dflash n_layer assignment after hparams getter refactor#103
Merged
Conversation
The upstream sync (#93) vendored the llama_hparams getter refactor: n_layer is now a getter returning n_layer_all - n_layer_nextn, with the settable member renamed. test-dflash still assigned the getter, breaking every CUDA/cpu CI build since 2026-06-07. n_layer_nextn defaults to 0, so n_layer_all = 5 preserves the tests' intent exactly. Verified: test-dflash compiles and all cases pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unbreaks CI: every CUDA/cpu PR build since the #93 upstream sync (2026-06-07) fails compiling
tests/test-dflash.cpp— the sync vendored upstream'sllama_hparamsgetter refactor (n_layeris nown_layer_all - n_layer_nextn), but the test still assignedhparams.n_layer.n_layer_nextndefaults to 0, son_layer_all = 5preserves the tests' intent exactly.Verified locally:
test-dflashcompiles and all cases pass (sm_86 build,All DFlash unit tests passed.).Found while triaging PR #102's CI — the failures predate that branch; once this lands, re-running #102's checks should clear the CUDA/cpu legs.
🤖 Generated with Claude Code