chore(server): drop embedded heierchat snapshot — restore upstream UI default#101
Merged
Merged
Conversation
… default The heierchat snapshot at tools/server/public/ was wired into llama-server as priority 1 in scripts/ui-assets.cmake, overriding the LLAMA_USE_PREBUILT_UI HF-bucket download even though that flag defaults ON. The snapshot expects a heierchat-app backend that isn't present on bare llama-server, which causes the embedded webui to hang on "Initializing connection to heierchat server…" when hit at llama-server's root. Now that heierchat is a standalone product talking to llama-server over its OpenAI-compatible API, the embedded UI reverts to the upstream llama.cpp default — fetched as a prebuilt bundle from the llama-ui HF bucket at build time via the existing tools/ui/ cmake scaffolding (no nodejs required, no fork-side build). Behaviour after this commit: - copy_public_dist priority 1 → MISS (public/ removed) - copy_src_dist priority 2 → MISS (tools/ui/src/ has no svelte sources) - BUILD_UI npm priority 3 → no-op (no source to build) - HF_ENABLED priority 4 → downloads upstream llama-ui bundle, embeds via llama-ui-embed (C++, host-compiler only) Docs updated to reflect the new arrangement. The copy_public_dist cmake function is preserved as a manual override for local experimentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tools/server/public/(15.5k-line heierchat snapshot) so the cmake fall-through picks the upstream prebuilt UI from thellama-uiHF bucket via the existingLLAMA_USE_PREBUILT_UI=ONdefault.llama-server.llama-serverover its OpenAI-compatible API.Behaviour after merge
scripts/ui-assets.cmakepriority chain:copy_public_dist(tools/server/public/) → MISS (removed)copy_src_dist(tools/ui/dist) → MISS (no svelte sources in tools/ui/src/)BUILD_UI=ONnpm build → no-op (no source to build)HF_ENABLED=ON→ downloads upstreamllama-uibundle, embeds viallama-ui-embed(C++ host-compiler only — no node)Snoop-kube confirmed the monolith Dockerfile can drop nodejs from stage1 once this lands (paired change, pinned via
--build-arg HT_SHA=<this-merge-sha>).Test plan
git rmremoves the 4 snapshot files cleanlycurl http://crystal:8080/ | grep -c heierchat→ 0